[3.14] gh-136759: rename lock.h to pylock.h (GH-137041)#137072
Closed
miss-islington wants to merge 2 commits intopython:3.14python/cpython:3.14from
miss-islington:backport-ec02db5-3.14miss-islington/cpython:backport-ec02db5-3.14Copy head branch name to clipboard
Closed
[3.14] gh-136759: rename lock.h to pylock.h (GH-137041)#137072miss-islington wants to merge 2 commits intopython:3.14python/cpython:3.14from miss-islington:backport-ec02db5-3.14miss-islington/cpython:backport-ec02db5-3.14Copy head branch name to clipboard
lock.h to pylock.h (GH-137041)#137072miss-islington wants to merge 2 commits intopython:3.14python/cpython:3.14from
miss-islington:backport-ec02db5-3.14miss-islington/cpython:backport-ec02db5-3.14Copy head branch name to clipboard
Conversation
Rename `lock.h` to `pylock.h` to avoid conflicts with headers of other projects. (cherry picked from commit ec02db5) Co-authored-by: AN Long <aisk@users.noreply.github.com>
This was referenced Jul 24, 2025
Contributor
|
All PRs on 3.14 branch are failing, so I don't think this is related and we can wait for the fix. |
ZeroIntensity
approved these changes
Jul 24, 2025
Member
ZeroIntensity
left a comment
There was a problem hiding this comment.
CI seems to be all good.
kumaraditya303
approved these changes
Jul 25, 2025
Contributor
|
According to #137075, I think we should close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
lock.htopylock.hto avoid conflicts with headers of other projects.(cherry picked from commit ec02db5)
Co-authored-by: AN Long aisk@users.noreply.github.com