Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.14] gh-136976: Emscripten: Add _decimal and libmpdec (GH-136997)#137066

Merged
hugovk merged 2 commits intopython:3.14python/cpython:3.14from
miss-islington:backport-ecb3f23-3.14miss-islington/cpython:backport-ecb3f23-3.14Copy head branch name to clipboard
Jul 29, 2025
Merged

[3.14] gh-136976: Emscripten: Add _decimal and libmpdec (GH-136997)#137066
hugovk merged 2 commits intopython:3.14python/cpython:3.14from
miss-islington:backport-ecb3f23-3.14miss-islington/cpython:backport-ecb3f23-3.14Copy head branch name to clipboard

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 24, 2025

Adds tooling to build mpdec (and thus _decimal) as part of an Emscripten build.
(cherry picked from commit ecb3f23)

Co-authored-by: Hood Chatham roberthoodchatham@gmail.com

Adds tooling to build mpdec (and thus _decimal) as part of an Emscripten build.
(cherry picked from commit ecb3f23)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@hoodmane
Copy link
Contributor

Huh:

c_parser.preprocessor.errors.ErrorDirectiveError: [gcc] (/home/runner/work/cpython/cpython/Modules/clinic/_testclinic_depr.c.h) #error directive hit (30 | #  error "Update the clinic input of '_testclinic.DeprStarNew.__new__'.")

Not sure why that would be related to this...

@hoodmane
Copy link
Contributor

It failed on both so I guess it's broken on 3.14 branch cc @hugovk

@zware
Copy link
Member

zware commented Jul 28, 2025

@hugovk Could we go ahead and merge this to simplify using it on the Emscripten buildbot worker?

@hugovk hugovk merged commit 38a42fe into python:3.14 Jul 29, 2025
50 checks passed
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
…GH-136997) (python#137066)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Co-authored-by: Zachary Ware <zach@python.org>
@miss-islington miss-islington deleted the backport-ecb3f23-3.14 branch January 2, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.