gh-137054: Remove obsolete counting of objects in young generation#137055
Merged
kumaraditya303 merged 1 commit intopython:mainpython/cpython:mainfrom Jul 24, 2025
sergey-miryanov:remove-dead-py-stats-from-gcsergey-miryanov/cpython:remove-dead-py-stats-from-gcCopy head branch name to clipboard
Merged
gh-137054: Remove obsolete counting of objects in young generation#137055kumaraditya303 merged 1 commit intopython:mainpython/cpython:mainfrom sergey-miryanov:remove-dead-py-stats-from-gcsergey-miryanov/cpython:remove-dead-py-stats-from-gcCopy head branch name to clipboard
kumaraditya303 merged 1 commit intopython:mainpython/cpython:mainfrom
sergey-miryanov:remove-dead-py-stats-from-gcsergey-miryanov/cpython:remove-dead-py-stats-from-gcCopy head branch name to clipboard
Conversation
- Now OBJECT_STAT_INC used to count and GC_STAT_ADD at the end of collect to adjust
Contributor
Author
|
I believe this should skip news. |
kumaraditya303
approved these changes
Jul 24, 2025
Contributor
Author
|
Thanks! |
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…ion under `Py_STATS` builds (python#137055)
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…ion under `Py_STATS` builds (python#137055)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found a dead code in gc.c for young generation.
cpython/Python/gc.c
Lines 1334 to 1342 in ec7fad7
It is superseded by counting of
object_visitsviaOBJECT_STAT_INCand adjustedgc_stats[gen].object_visitsat the end of the collection.cpython/Python/gc.c
Lines 2073 to 2079 in ec7fad7
I believe it is worth to remove dead code to decrease code base (yeah, by 9 lines).
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response