Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-136437: Make several functions in os.path pos-only#136949

Merged
sobolevn merged 5 commits intopython:mainpython/cpython:mainfrom
sobolevn:issue-136437-3sobolevn/cpython:issue-136437-3Copy head branch name to clipboard
Jul 23, 2025
Merged

gh-136437: Make several functions in os.path pos-only#136949
sobolevn merged 5 commits intopython:mainpython/cpython:mainfrom
sobolevn:issue-136437-3sobolevn/cpython:issue-136437-3Copy head branch name to clipboard

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 21, 2025

Marking functions from #136812 and #136946 as accepting pos-only.

Not to be backported.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not it update also samestat, samefile, maybe other functions in genericpath?

Modules/posixmodule.c Outdated Show resolved Hide resolved
@sobolevn
Copy link
Member Author

Yes, I missed samestat and probably several others when created first PR. Because they have (s1, s2) which escaped my regex. We first need to document them as pos-only. Thanks for the good catch!

@sobolevn sobolevn marked this pull request as draft July 22, 2025 09:05
@sobolevn
Copy link
Member Author

I created #136970 to fix first

@AA-Turner
Copy link
Member

I created #136970 to fix first

Merged.

A

@sobolevn sobolevn marked this pull request as ready for review July 22, 2025 15:03
Modules/posixmodule.c Outdated Show resolved Hide resolved
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sobolevn
Copy link
Member Author

sobolevn commented Jul 22, 2025

Thanks everyone! Will leave open till tomorrow and merge :)

@sobolevn sobolevn merged commit 99cdf1d into python:main Jul 23, 2025
44 checks passed
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.