Fix various user-visible typos#136884
Fix various user-visible typos#136884corneliusroemer wants to merge 3 commits intopython:mainpython/cpython:mainfrom corneliusroemer:typos-reviewedcorneliusroemer/cpython:typos-reviewedCopy head branch name to clipboard
Conversation
Typos were identified by google.jules and manually reviewed for correctness
|
You need to run |
|
@StanFromIreland Thanks! I had already noticed and run |
AA-Turner
left a comment
There was a problem hiding this comment.
As with your other PR -- mass spelling error PRs are generally unhelpful. This one has already been approved by Peter though, and is much smaller, so happier to keep it.
A
Doc/bugs.rst
Outdated
| It can be sometimes faster to fix bugs yourself and contribute patches to | ||
| Python as it streamlines the process and involves less people. Learn how to | ||
| It can sometimes be faster to fix bugs yourself and contribute patches to | ||
| Python as it streamlines the process and involves fewer people. Learn how to |
There was a problem hiding this comment.
This is arguable, please revert
There was a problem hiding this comment.
done, I don't think less is not a grammar error but I'm happy to remove it
There was a problem hiding this comment.
@corneliusroemer sorry, I only meant to revert line 12 (less v fewer) -- fixing the split infinitive on L11 is fine to keep.
There was a problem hiding this comment.
Sorry, I overcorrected. Could you maybe explain your reasoning behind not changing "less people"?
People often use less with countable nouns There were less cars on the road then. This is not considered correct in standard English, and fewer should be used instead.
-- Oxford Learner's Dictionary: https://www.oxfordlearnersdictionaries.com/definition/english/less_1?q=less:
There was a problem hiding this comment.
Because English is silly and everyone understands "less" anyway. More practically, we don't want to inspire copycat PRs that change "less" to "fewer" everywhere.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I approved this on the basis that this is changing actual documentation, so typo fixes are actually useful to readers. I refrained from immediately merging for fear that someone would be concerned about the churn, so if anyone is strongly opposed, please speak up. |
|
If you don't want typo fixes in comments, maybe you can make this explicit in the docs? I can't find guidance saying "We don't want fixes to typos in comments". Not being explicitly welcomed doesn't mean unwelcome. And typo fixes aren't formatting.
https://devguide.python.org/getting-started/pull-request-lifecycle/ |
|
It's somewhat of a grey area. Mainly what we don't want is large PRs touching lots of files. We also want to avoid churn. Therefore, some 'comment typo' PRs are accepted, and some are rejected -- there's no bright line to point to, nor a hard and fast rule. A |
|
Alright, I hope those 2 PRs are acceptable - those are the most docs/docstring-like from the big PR:
Grouped and scoped |
b874154 to
5c88a7a
Compare
freakboy3742
left a comment
There was a problem hiding this comment.
FWIW, since I was tagged; the one change to the iOS docs is a substantive and useful change.
|
Sorry for changing your title but this one would be too long for a commit message. I changed the other because there were only two files. Ideally, I prefer having one PR for fixing specific typos in specific places instead of having one PR touching many files but since Peter accepted this one, I won't ask you to split it again. |
ned-deily
left a comment
There was a problem hiding this comment.
The Mac/BuildScript/README.rst change is fine, thanks.
freakboy3742
left a comment
There was a problem hiding this comment.
iOS fix makes sense to me.
Typos were identified by https://jules.google and manually reviewed for correctness (there were a bunch of false positives).
📚 Documentation preview 📚: https://cpython-previews--136884.org.readthedocs.build/