gh-124621: Emscripten: Fix regression in use-after-close error handling#136837
Merged
ambv merged 1 commit intopython:mainpython/cpython:mainfrom Jul 19, 2025
hoodmane:emscripten-async-input-device-fixhoodmane/cpython:emscripten-async-input-device-fixCopy head branch name to clipboard
Merged
gh-124621: Emscripten: Fix regression in use-after-close error handling#136837ambv merged 1 commit intopython:mainpython/cpython:mainfrom hoodmane:emscripten-async-input-device-fixhoodmane/cpython:emscripten-async-input-device-fixCopy head branch name to clipboard
ambv merged 1 commit intopython:mainpython/cpython:mainfrom
hoodmane:emscripten-async-input-device-fixhoodmane/cpython:emscripten-async-input-device-fixCopy head branch name to clipboard
Conversation
8456068 to
a75d42e
Compare
…handling Introduced in pythonGH-136822. If the fd is already closed, `SYSCALLS.getStreamFromFD()` throws an error. We need to catch it and discard it. The `__wasi_fd_read_orig()` fallback will use it to set errno.
a75d42e to
eea3a60
Compare
Contributor
Author
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit eea3a60 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136837%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
hoodmane
added a commit
to miss-islington/cpython
that referenced
this pull request
Jul 22, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in GH-136822. If the fd is already closed,
SYSCALLS.getStreamFromFD()throws an error. We need to catch it and discard it. The__wasi_fd_read_orig()fallback will use it to set errno.