Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-136264: Fix PEP-739 build-details generation with relative-paths#136265

Closed
itamaro wants to merge 1 commit intopython:mainpython/cpython:mainfrom
itamaro:fix-build-details-relpathsitamaro/cpython:fix-build-details-relpathsCopy head branch name to clipboard
Closed

gh-136264: Fix PEP-739 build-details generation with relative-paths#136265
itamaro wants to merge 1 commit intopython:mainpython/cpython:mainfrom
itamaro:fix-build-details-relpathsitamaro/cpython:fix-build-details-relpathsCopy head branch name to clipboard

Conversation

@itamaro
Copy link
Contributor

@itamaro itamaro commented Jul 4, 2025

there were two issues with the make_paths_relative implementation:

  1. for top-level entries (i.e. base_interpreter), the parent is "", leading to the part loop to set the container to the non-existent top-level "" key, which becomes {} because it's a defaultdict
  2. for dotted-entries that don't exist in the data, current_path ends up being {}, again, because it's a defaultdict

this PR proposes one (granted, somewhat sus) way to fix it, by:

  1. checking the truthyness of part before indexing into the container (fixing the first issue)
  2. explicitly raising the KeyError when it would have been otherwise raised by a non-defaultdict dict (fixing the second issue)

@AA-Turner
Copy link
Member

Closed by #138510.

A

@AA-Turner AA-Turner closed this Sep 8, 2025
@itamaro itamaro deleted the fix-build-details-relpaths branch September 9, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.