gh-136251: Improvements to WASM demo REPL#136252
gh-136251: Improvements to WASM demo REPL#136252ambv merged 23 commits intopython:mainpython/cpython:mainfrom
Conversation
….worker.mjs can use it
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
sobolevn
left a comment
There was a problem hiding this comment.
not a full review, just saw some style problems :)
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
thanks, @sobolevn! i just ran |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
I broke this on the main branch again (in one place I check for |
|
Merged main and pushed a commit fixing the problem. I'll run the Emscripten buildbot on this and if it passes it is good to merge. |
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 26ddd07 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136252%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Okay it needs the fix from #136909 to unbreak the buildbot... |
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 7d33525 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136252%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Sorry, @adqm and @ambv, I could not cleanly backport this to |
|
Looks like first we have to backport #136822. |
(cherry picked from commit d1d526a) Co-authored-by: adam j hartz <adam@smatz.net> Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
|
GH-136977 is a backport of this pull request to the 3.14 branch. |
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
…) (pythonGH-136977) (cherry picked from commit d1d526a) Co-authored-by: adam j hartz <adam@smatz.net> Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
I'm including a couple of fixes for the WASM demo, which for me made the demo "just work" out of the box for me with a build from following the instructions on this page:
HEAPU32at build time sincepython.worker.mjsexpects it to be there (for determining the version number)xterm.jsI also made a few changes to try to improve the usability of the web REPL, also included here:
textareawith Ace code editor.index.htmlinstead ofpython.htmlso that the URL shown in the terminal when runningserver.pytakes you to the demo (without needing to append/python.html)I also put up a demo here that shows the result of a fresh Emscripten build with these changes.
There's definitely still room for improvement here (for example, #124621 suggests updating the demo to use PyREPL), but I'm sharing these changes in case they're useful in the meantime.
Related Issue: #136251