-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-134486: Fix missing alloca symbol in _ctypes on NetBSD. #134487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
!buildbot BSD |
🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit 46b0d9d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134487%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, buildbot failure looks unrelated.
Misc/NEWS.d/next/Build/2025-05-21-22-13-30.gh-issue-134486.yvdL6f.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Build/2025-05-21-22-13-30.gh-issue-134486.yvdL6f.rst
Outdated
Show resolved
Hide resolved
46b0d9d
to
2103a25
Compare
Previously the module would fail to load because the ``alloca`` symbol was undefined. Now we check for GCC/Clang builtins for systems who do not define ``alloca`` in headers.
2103a25
to
93f6e60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The issue occurs on NetBSD 10.0 (ARM architecture)
. As a check, I tested the changes in the PR on NetBSD 10.0 (amd64)
and got a successful build.
Merged, thank you. |
Previously the module would fail to load because the
alloca
symbol was undefined. Now we check for GCC/Clang builtins for systems who do not definealloca
in headers.alloca
symbol #134486