Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-134486: Fix missing alloca symbol in _ctypes on NetBSD. #134487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

collinfunk
Copy link
Contributor

@collinfunk collinfunk commented May 22, 2025

Previously the module would fail to load because the alloca symbol was undefined. Now we check for GCC/Clang builtins for systems who do not define alloca in headers.

@AA-Turner
Copy link
Member

!buildbot BSD

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit 46b0d9d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134487%2Fmerge

The command will test the builders whose names match following regular expression: BSD

The builders matched are:

  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, buildbot failure looks unrelated.

Modules/_ctypes/ctypes.h Outdated Show resolved Hide resolved
Modules/_ctypes/ctypes.h Outdated Show resolved Hide resolved
@collinfunk collinfunk force-pushed the fix-alloca-definition branch from 46b0d9d to 2103a25 Compare May 23, 2025 01:30
Previously the module would fail to load because the ``alloca`` symbol
was undefined. Now we check for GCC/Clang builtins for systems who do
not define ``alloca`` in headers.
@collinfunk collinfunk force-pushed the fix-alloca-definition branch from 2103a25 to 93f6e60 Compare May 23, 2025 01:43
@collinfunk collinfunk requested a review from vstinner May 23, 2025 01:44
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@furkanonder furkanonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The issue occurs on NetBSD 10.0 (ARM architecture). As a check, I tested the changes in the PR on NetBSD 10.0 (amd64) and got a successful build.

@vstinner vstinner merged commit b8f5526 into python:main May 23, 2025
43 checks passed
@vstinner
Copy link
Member

Merged, thank you.

@collinfunk collinfunk deleted the fix-alloca-definition branch May 23, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.