Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-132542: Only run test_native_id_after_fork if native_id is supported #134408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

gh-132542: Only run test_native_id_after_fork if native_id is supported #134408

merged 1 commit into from
May 21, 2025

Conversation

noamcohen97
Copy link
Contributor

@noamcohen97 noamcohen97 commented May 21, 2025 •
edited
Loading

This should also be backported to 3.13 and 3.14

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label May 21, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 21, 2025
Closed
@noamcohen97 noamcohen97 mentioned this pull request May 21, 2025
Merged
serhiy-storchaka
serhiy-storchaka approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news labels May 21, 2025
@noamcohen97
Copy link
Contributor Author

Thanks @serhiy-storchaka!

@serhiy-storchaka serhiy-storchaka merged commit e6dde10 into python:main May 21, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks @noamcohen97 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
@noamcohen97 @miss-islington
pythongh-132542: Only run test_native_id_after_fork if native_id is s…
5ac7ca4 
…upported (pythonGH-134408)

(cherry picked from commit e6dde10)

Co-authored-by: Noam Cohen <noam@noam.me>
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2025

GH-134413 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
@noamcohen97 @miss-islington
pythongh-132542: Only run test_native_id_after_fork if native_id is s…
44f9ec5 
…upported (pythonGH-134408)

(cherry picked from commit e6dde10)

Co-authored-by: Noam Cohen <noam@noam.me>
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2025

GH-134414 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 21, 2025
@noamcohen97 noamcohen97 deleted the skip-native-id-test-if-not-supported branch May 21, 2025 11:11
serhiy-storchaka pushed a commit that referenced this pull request May 21, 2025
@miss-islington @noamcohen97
[3.13] gh-132542: Only run test_native_id_after_fork if native_id is …
f5de063 
…supported (GH-134408) (GH-134414)

(cherry picked from commit e6dde10)

Co-authored-by: Noam Cohen <noam@noam.me>
serhiy-storchaka pushed a commit that referenced this pull request May 21, 2025
@miss-islington @noamcohen97
[3.14] gh-132542: Only run test_native_id_after_fork if native_id is …
7c3e215 
…supported (GH-134408) (GH-134413)

(cherry picked from commit e6dde10)

Co-authored-by: Noam Cohen <noam@noam.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noamcohen97 @serhiy-storchaka
Morty Proxy This is a proxified and sanitized view of the page, visit original site.