gh-131798: JIT: replace _LOAD_SMALL_INT with

`_LOAD_CONST_INLINE_BORROW` Signed-off-by: Manjusaka <me@manjusaka.me> add news Signed-off-by: Manjusaka <me@manjusaka.me> add tests Signed-off-by: Manjusaka <me@manjusaka.me> fix review idea Signed-off-by: Manjusaka <me@manjusaka.me>
python · brandtbucher · May 22, 2025 · May 21, 2025 · May 22, 2025 · May 22, 2025
commit ee6e90bfab9600b54cf7a83675356b8beeb3678b
diff --git a/Lib/test/test_capi/test_opt.py b/Lib/test/test_capi/test_opt.py
@@ -2156,6 +2156,17 @@ def testfunc(n):
        self.assertIn("_GUARD_TYPE_VERSION", uops)
        self.assertNotIn("_CHECK_ATTR_CLASS", uops)

+    def test_load_small_int(self):
+        def testfunc(n):
+            x = 0
+            for i in range(n):
+                x += 1
+            return x
+        res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
+        self.assertEqual(res, TIER2_THRESHOLD)
+        self.assertIsNotNone(ex)
+        uops = get_opnames(ex)
+        self.assertIn("_LOAD_CONST_INLINE_BORROW", uops)

 def global_identity(x):
    return x

diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-05-21-13-57-26.gh-issue-131798.QwS5Bb.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-05-21-13-57-26.gh-issue-131798.QwS5Bb.rst
@@ -0,0 +1 @@
+JIT: replace ``_LOAD_SMALL_INT`` with ``_LOAD_CONST_INLINE_BORROW``
@@ -529,6 +529,7 @@ dummy_func(void) {

    op(_LOAD_SMALL_INT, (-- value)) {
        PyObject *val = PyLong_FromLong(this_instr->oparg);
+        REPLACE_OP(this_instr, _LOAD_CONST_INLINE_BORROW, 0, (uintptr_t)val);
        value = sym_new_const(ctx, val);
    }


diff --git a/Python/optimizer_cases.c.h b/Python/optimizer_cases.c.h
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		JIT: replace ``_LOAD_SMALL_INT`` with ``_LOAD_CONST_INLINE_BORROW``
-Original file line number
+Diff line change
@@ -529,6 +529,7 @@ dummy_func(void) {
         op(_LOAD_SMALL_INT, (-- value)) {
             PyObject *val = PyLong_FromLong(this_instr->oparg);
                   Zheaoli marked this conversation as resolved.
              

          
            Show resolved
            Hide resolved
        

                
  
            
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.
+            REPLACE_OP(this_instr, _LOAD_CONST_INLINE_BORROW, 0, (uintptr_t)val);
                   Zheaoli marked this conversation as resolved.
              

          
            Show resolved
            Hide resolved
        

                
  
            
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.
             value = sym_new_const(ctx, val);
         }
-          Expand Down