gh-90871: fix connection backlog offset in asyncio #134392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ChristianHrs
commented
May 20, 2025
•
- Issue: asyncio.create_unix_server has an off-by-one error concerning the backlog parameter #90871
…ed log once through the exception handler
…tests for 0 and 1 connections
…ted new tests for 0 and 1 connections" This reverts commit 17d39e9.
…or 0 and 1" This reverts commit 2c603b9.
…ions log once through the exception handler (pythongh-134331)" This reverts commit f695eca.
…g=0 and backlog=1
Misc/NEWS.d/next/Library/2025-05-20-21-45-58.gh-issue-90871.Gkvtp6.rst
Outdated
Show resolved
Hide resolved
kumaraditya303
approved these changes
May 21, 2025
There was a problem hiding this comment.
As per FreeBSD docs and https://www.man7.org/linux/man-pages/man2/listen.2.html about backlog, this is correct.
|
Thanks @ChristianHrs for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2025
|
GH-134421 is a backport of this pull request to the 3.14 branch. |
|
Thanks @ChristianHrs for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @ChristianHrs and @ambv, I could not cleanly backport this to |
|
To backport to 3.13, we might consider backporting #127532 first. |
ambv
added a commit
that referenced
this pull request
May 21, 2025
…gh-134421) (cherry picked from commit 109f759) Co-authored-by: Christian Harries <68507104+ChristianHrs@users.noreply.github.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.