gh-134360 Add processName attribute to logging.Formatter docstring
#134371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add processName to logging.Formatter docstring
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
vsajip
approved these changes
May 21, 2025
|
Thanks @SofieTorch for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @SofieTorch for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2025
…tring (pythonGH-134371) (cherry picked from commit c740fe3) Co-authored-by: Sofia Toro <sofie.torch@outlook.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2025
…tring (pythonGH-134371) (cherry picked from commit c740fe3) Co-authored-by: Sofia Toro <sofie.torch@outlook.com>
|
GH-134404 is a backport of this pull request to the 3.13 branch. |
|
GH-134405 is a backport of this pull request to the 3.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the issue #134360 suggests, the
Formatterclass was missing theprocessNameattribute inside its docstring.I've added the attribute to the docstring and made sure that it actually is in the
LogRecordclass. Now it is just as in the LogRecord attributes section of the Python documentation.logging.Formatterdocstring missing processName attribute. #134360