Improve permission error messages in pdb and asyncio.tools #134290
Conversation
Add help texts for Linux, macOS, and Windows to guide users in resolving permission errors when attaching to a process using the -p option.
Add platform-specific guidance to help users resolve permission errors when inspecting running processes with asyncio.tools.
2b62a35 to
6101e33
Compare
|
CC @pablogsal |
| This function is called when a PermissionError is encountered while trying | ||
| to attach to a process. | ||
| """ | ||
| system = platform.system() |
There was a problem hiding this comment.
sys is already imported, so you can use sys.platform
|
Should this live in the code? I think this should live in the docs and we should just print a link for it. This documentation should probably live with |
I think so. We want to provide actionable output to the users right where the error happens and not just in the docs. We could put it somewhere in the docs and drop a link there though although I think that is slight worse experience. But I don't feel very strongly |
|
I think this is too much text living in the code - especially with multiple copies. If we have a third library that utilizes I suggest that we put a link to the docs in the |
This PR enhances the user experience when a
PermissionErroroccurs while attempting to attach to a process usingpdb -por tools likeasyncio psandasyncio pstree. It adds platform-specific guidance for Linux, macOS, and Windows to help users understand why the operation failed and how to resolve it (e.g., usingsudo, adjusting system settings, or enabling debugging privileges).Currently, the same logic is duplicated in both
pdbandasyncio.tools. If anyone has recommendations on how to avoid this duplication, I’d appreciate input. I couldn't find a clear shared location in the standard library where this kind of utility logic would belong.