Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-132983: Add zstd version info to test.pythoninfo #134230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 19, 2025
Merged

gh-132983: Add zstd version info to test.pythoninfo #134230

merged 6 commits into from
May 19, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented May 19, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 19, 2025
Closed
13 tasks
vstinner
vstinner approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a minor PEP 8 remark. But the CI is failing.

Lib/test/pythoninfo.py Show resolved Hide resolved
@vstinner
Copy link
Member

Tests / Ubuntu / build and test (ubuntu-24.04) (pull_request)Failing after 3m

Unexpected warnings:
Include/opcode_ids.h expected 0 warnings, found 2
{'file': 'Include/opcode_ids.h', 'line': '132', 'column': '48', 'message': 'initialized field overwritten', 'option': '-Woverride-init'}
{'file': 'Include/opcode_ids.h', 'line': '133', 'column': '48', 'message': 'initialized field overwritten', 'option': '-Woverride-init'}

@StanFromIreland
Copy link
Contributor Author

Fails are unrelated from what I can tell, most should be resolved by updating the branch as pr's fixing have been merged.

Docs test will fail, but it is fine since #133911 will be merged soon enough.

@StanFromIreland
Copy link
Contributor Author

Yep, all [excluding expected fail] test pass.

@vstinner
Copy link
Member

I clicked on [Update branch] to try to repair the CI.

@vstinner
Copy link
Member

@StanFromIreland: There is an issue in the doc:

/home/runner/work/cpython/cpython/Doc/build/NEWS:74: WARNING: py:mod reference target not found: compression.zstd [ref.mod]

@StanFromIreland @vstinner
Update Misc/NEWS.d/next/Library/2025-05-19-15-30-00.gh-issue-132983.a…
4d38115 
…sdsfs.rst

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner merged commit 46d7c11 into python:main May 19, 2025
39 checks passed
@vstinner
Copy link
Member

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@emmatyping emmatyping emmatyping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanFromIreland @vstinner @emmatyping
Morty Proxy This is a proxified and sanitized view of the page, visit original site.