Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-134152: fix UnboundLocalError while parsing message_id in email #134194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
Loading
from
Open

gh-134152: fix UnboundLocalError while parsing message_id in email #134194

wants to merge 6 commits into from
+8 −1

Conversation

sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented May 18, 2025 •
edited
Loading

There are two errors:

  1. The first one from original issue for UnboundLocalError
  2. The second one I observed when tried write a test for parse_message_id - I found that in some cases error placed to the list of tokens not of defects.

@sergey-miryanov sergey-miryanov requested a review from a team as a code owner May 18, 2025 18:42
@bedevere-app bedevere-app bot mentioned this pull request May 18, 2025
Open
picnixz
picnixz reviewed May 18, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @bitdancer

The defects fix seems right

Misc/NEWS.d/next/Library/2025-05-18-23-46-21.gh-issue-134152.30HwbX.rst Outdated Show resolved Hide resolved
@picnixz picnixz changed the title gh-134152: fix unbound local error while parsing message_id in email gh-134152: fix UnboundLocalError while parsing message_id in email May 18, 2025
@sergey-miryanov @picnixz
Update Misc/NEWS.d/next/Library/2025-05-18-23-46-21.gh-issue-134152.3…
5174b65 
…0HwbX.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bitdancer
Copy link
Member

Drat. I somehow missed your PR before I submitted mine (#134233). We should combine the two. You want to pull in the extra tests from mine? Thanks for catching the defect issue.

I think my early return is clearer than setting pos=0 even though they have the same effect.

@sergey-miryanov
Copy link
Contributor Author

Yeah, your solution with early return looks better than mine.

I'm happy to revert my changes with pos=0 and keep only defects fix. After this we can keep two PRs or merge one with other. This is up to you because I'm very new here.

@bitdancer bitdancer mentioned this pull request May 19, 2025
Open
@sergey-miryanov
Revert "Fix handling of empty strings in .get_dtext, .get_qp_ctext an…
cf0a4ea 
…d .get_qcontent"

This reverts commit 5c3fa11.
@sergey-miryanov
Merge branch 'pythongh-134152-fix-unbound-local-error-in-email' of gi…
1ff7bcb 
…thub.com:sergey-miryanov/cpython into pythongh-134152-fix-unbound-local-error-in-email
@sergey-miryanov
Copy link
Contributor Author

Tests should pass after #134233 will be merged.

@bitdancer
Copy link
Member

Sure, that works for me.

@sergey-miryanov
Copy link
Contributor Author

@bitdancer I'm sorry to bother you. Perhaps I misunderstood you. Do you expect me to merge your PR with this one?

@bitdancer
Copy link
Member

No, I just haven't gotten around to merging mine yet. I'll do it soon ;)

@sergey-miryanov
Copy link
Contributor Author

Thanks! I wasn't sure that I got you right, so I thought I'd clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergey-miryanov @bitdancer @picnixz
Morty Proxy This is a proxified and sanitized view of the page, visit original site.