gh-134043: add _PyObject_GetMethodStackRef
#134044
Open
+123
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thon; branch 'main' of https://github.com/python/cpython into stackref-call
colesbury
reviewed
May 22, 2025
| if (attr != NULL) { | ||
| PyStackRef_CLEAR(*method); | ||
| *method = PyStackRef_FromPyObjectSteal(attr); | ||
| goto exit; |
There was a problem hiding this comment.
I think that a return 0 instead of goto exit would make it easier to understand the code as well as see how it matches with _PyObject_GetMethod.
(Same for the goto exit statements below)
| tp->tp_name, name); | ||
|
|
||
| _PyObject_SetAttributeErrorContext(obj, name); | ||
| PyStackRef_CLEAR(*method); |
There was a problem hiding this comment.
*method should always be NULL here. If it's not NULL, we exit earlier, such as through the descr != NULL case above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_PyObject_GetMethodand calling APIs #134043