gh-133485: Use _interpreters.call() in InterpreterPoolExecutor #133957
+1,213
−336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5340a57 to
62d7c2c
Compare
6787fbf to
4dd556a
Compare
4dd556a to
e7e950c
Compare
f1208ff to
b3c2477
Compare
b3c2477 to
7697c11
Compare
Comment on lines
+23
to
+26
| # InterpreterPoolInitializerTest.test_initializer fails | ||
| # if we don't have a LOAD_GLOBAL. (It could be any global.) | ||
| # We will address this separately. | ||
| INITIALIZER_STATUS |
There was a problem hiding this comment.
@markshannon, any ideas on why this is happening? It smells like a ceval bug, but it certainly could be something I've done wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly, this resolves the issues with functions and types defined in
__main__.It also expands the number of supported objects.
(This is based on gh-133484, thus only the last commit.)