gh-133829: Update zipimport example to not be from Python 2 #133835
Conversation
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
@AA-Turner i completely removed the bash part to make a MWE |
|
I'd suggest using Ryan's example on the issue, currently there's no provenance for pip.pyz. |
|
Will do soon
…On Sat, May 10, 2025 at 19:13 Adam Turner ***@***.***> wrote:
*AA-Turner* left a comment (python/cpython#133835)
<#133835 (comment)>
I'd suggest using Ryan's example on the issue, currently there's no
provenance for pip.pyz.
—
Reply to this email directly, view it on GitHub
<#133835 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNITW5YAIEXLM2CV4MCOHB3252BYPAVCNFSM6AAAAAB425AMWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRZGIYTCMRRHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…and ``import example``
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
|
@AA-Turner Please give final review |
|
Someone please merge this since @AA-Turner isnt reviewing any time soon |
|
Let's be patient! Adam will review when he gets a chance to do so. People are busy, and complaining doesn't get it landed any faster (though sometimes I wish it did 😉) |
|
Sorry, bad mood that day :) finals
…On Sun, May 18, 2025 at 10:28 AM Peter Bierma ***@***.***> wrote:
*ZeroIntensity* left a comment (python/cpython#133835)
<#133835 (comment)>
Let's be patient! Adam will review when he gets a chance to do so. People
are busy, and complaining doesn't get it landed any faster (though
sometimes I wish it did 😉)
—
Reply to this email directly, view it on GitHub
<#133835 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNITW5YDDF5JIKSGGUQNGPD27CKJZAVCNFSM6AAAAAB425AMWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBZGAZDCOJQGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
#133829
Updates this zipimport example: https://docs.python.org/3.14/library/zipimport.html#examples which uses Python 2.3 to use 3.x and pip.pyz as the new example
This will close #133829
Ready for review
📚 Documentation preview 📚: https://cpython-previews--133835.org.readthedocs.build/en/133835/library/zipimport.html#examples