gh-133677: Skip test in test_httpservers if not utf-8
#133706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Calling the raspbian buildbots would verify this is solved. |
|
@StanFromIreland Is it okay if I handle the zipfile test fail? I worked alot with the zipfile lib |
This was referenced May 8, 2025
|
!buildbot raspbian |
|
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit e45a58d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133706%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Test passes on buildbot. |
zware
reviewed
May 9, 2025
zware
reviewed
May 9, 2025
Lib/test/test_httpservers.py
Outdated
| def test_undecodable_parameter(self): | ||
| # sanity check using a valid parameter | ||
| response = self.request(self.base_url + '/?x=123').read() | ||
| self.assertRegex(response, rf'listing for {self.base_url}/\?x=123'.encode('latin1')) | ||
| # now the bogus encoding | ||
| # now the bogus (utf-8) encoding |
There was a problem hiding this comment.
Comment should be reverted as well.
|
Sorry, but skipping the test is not a proper fix of this issue. Test failure exposes a bug in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latin-1#133677