gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 #133574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
approved these changes
May 11, 2025
Misc/NEWS.d/next/Windows/2025-05-07-13-04-22.gh-issue-133580.jBMujJ.rst
Outdated
Show resolved
Hide resolved
…BMujJ.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #102256 where I didn't properly set the exception. This didn't cause issues for me since I wrote this when I was still using Python 3.11 where this was structured differently.
sys.getwindowsversioncan fail without setting an exception on some WinAPI partitions #133580