gh-133448: Fix test_file in test_urllib2 on Windows with a longer repo path #133449
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aisk NB: The review would go a lot faster if you were to add a short PR description of your changes |
|
@sharktide Thanks for noticing, updated! |
sharktide
reviewed
May 6, 2025
There was a problem hiding this comment.
I know this is kinda a stupid question, but have you tested this new version of your test script on a windows long path? (I know people who wouldn't not saying its you just trying to expedite the core review process then) :)
*GitHub Actions won't fail because it is a short path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the
urlwould become something likefile://somerandomhost.ontheinternet.comC:\Users\xxxxx\Source\cpython\build\test_python_worker_4676æ/@test_4676_tmpæon Windows, which would fail (more details in the linked issue).In this PR, the
urlbecomesfile://somerandomhost.ontheinternet.com/Users/xxxxx/Source/cpython/build/test_python_worker_4676æ/@test_4676_tmpæ, which is valid and expected.test_filefailed on Windows with a longer repo path intest_urllib2#133448