fix review idea

Signed-off-by: Manjusaka <me@manjusaka.me>
python · brandtbucher · May 20, 2025 · May 3, 2025 · May 3, 2025 · May 3, 2025
commit 6b5282fbaee0d1c2fa9ef53f3b99b271531a7486
diff --git a/Lib/test/test_capi/test_opt.py b/Lib/test/test_capi/test_opt.py
@@ -1937,23 +1937,8 @@ def testfunc(n):
        self.assertEqual(len(res), TIER2_THRESHOLD)
        uops = get_opnames(ex)
        self.assertNotIn("_GUARD_NOS_INT", uops)
-        self.assertIn("_GET_LEN", uops)
-        self.assertIn("_POP_TOP_LOAD_CONST_INLINE_BORROW", uops)
+        self.assertIn("_LOAD_CONST_INLINE_BORROW", uops)

-    def test_get_len_with_non_const_tuple(self):
-        def testfunc(n):
-            x = 0.0
-            for _ in range(n):
-                match (object(), object()):
-                    case [_, _]:
-                        x += 1.0
-            return x
-        res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
-        self.assertEqual(int(res), TIER2_THRESHOLD)
-        uops = get_opnames(ex)
-        self.assertNotIn("_GUARD_NOS_INT", uops)
-        self.assertIn("_GET_LEN", uops)
-        self.assertIn("_POP_TOP_LOAD_CONST_INLINE_BORROW", uops)

    def test_get_len_with_non_tuple(self):
        def testfunc(n):
@@ -1969,22 +1954,6 @@ def testfunc(n):
        self.assertNotIn("_GUARD_NOS_INT", uops)
        self.assertIn("_GET_LEN", uops)

-    def test_get_len_with_immortal_tuple(self):
-        def testfunc(n):
-            class TestObject:
-                pass
-            x = 0.0
-            for _ in range(n):
-                match TestObject.__mro__:
-                    case (_, _,):
-                        x += 1.0
-            return x
-        res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
-        self.assertEqual(int(res), TIER2_THRESHOLD)
-        uops = get_opnames(ex)
-        self.assertIn("_GET_LEN", uops)
-        self.assertIn("_LOAD_CONST_INLINE_BORROW", uops)
-

    def test_binary_op_subscr_tuple_int(self):
        def testfunc(n):