Accept suggestions

python · sobolevn · May 4, 2025 · May 3, 2025 · May 3, 2025 · May 3, 2025
commit de328afc20b10ef45b8cd85488c91d0419c4d49a
@@ -3193,8 +3193,7 @@ def text_normalize(string):
        return textwrap.dedent(string).strip()

    def set_source(self, content):
-        with open(self.filename, 'w') as f:
-            f.write(self.text_normalize(content))
+        Path(self.filename).write_text(self.text_normalize(content))

    def invoke_ast(self, *flags):
        output = StringIO()
@@ -3207,16 +3206,16 @@ def check_output(self, source, expect, *flags):
            self.set_source(source)
            res = self.invoke_ast(*flags)
            expect = self.text_normalize(expect)
-            self.assertListEqual(res.splitlines(), expect.splitlines())
+            self.assertEqual(res, expect)

    def test_invocation(self):
        # test various combinations of parameters
-        base_flags = [
+        base_flags = (
            ('-m=exec', '--mode=exec'),
            ('--no-type-comments', '--no-type-comments'),
            ('-a', '--include-attributes'),
            ('-i=4', '--indent=4'),
-        ]
+        )
        self.set_source('''
            print(1, 2, 3)
            def f(x):
@@ -3250,15 +3249,15 @@ def test_mode_flag(self):
                           Constant(value=2),
                           Constant(value=3)]))])
        '''
-        for flag in ['-m=exec', '--mode=exec']:
+        for flag in ('-m=exec', '--mode=exec'):
            self.check_output(source, expect, flag)
        source = 'pass'
        expect = '''
            Interactive(
               body=[
                  Pass()])
        '''
-        for flag in ['-m=single', '--mode=single']:
+        for flag in ('-m=single', '--mode=single'):
            self.check_output(source, expect, flag)
        source = 'print(1, 2, 3)'
        expect = '''
@@ -3270,7 +3269,7 @@ def test_mode_flag(self):
                     Constant(value=2),
                     Constant(value=3)]))
        '''
-        for flag in ['-m=eval', '--mode=eval']:
+        for flag in ('-m=eval', '--mode=eval'):
            self.check_output(source, expect, flag)
        source = '(int, str) -> list[int]'
        expect = '''
@@ -3283,7 +3282,7 @@ def test_mode_flag(self):
                  slice=Name(id='int', ctx=Load()),
                  ctx=Load()))
        '''
-        for flag in ['-m=func_type', '--mode=func_type']:
+        for flag in ('-m=func_type', '--mode=func_type'):
            self.check_output(source, expect, flag)

    def test_no_type_comments_flag(self):
@@ -3312,7 +3311,7 @@ def test_include_attributes_flag(self):
                     end_lineno=1,
                     end_col_offset=4)])
        '''
-        for flag in ['-a', '--include-attributes']:
+        for flag in ('-a', '--include-attributes'):
            self.check_output(source, expect, flag)

    def test_indent_flag(self):
@@ -3323,7 +3322,7 @@ def test_indent_flag(self):
            body=[
            Pass()])
        '''
-        for flag in ['-i=0', '--indent=0']:
+        for flag in ('-i=0', '--indent=0'):
            self.check_output(source, expect, flag)