Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-131747: ctypes: Deprecate _pack_ implicitly setting _layout_ = 'ms' #133205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 5, 2025
Merged

gh-131747: ctypes: Deprecate _pack_ implicitly setting _layout_ = 'ms' #133205

merged 7 commits into from
May 5, 2025

Conversation

encukou
Copy link
Member

@encukou encukou commented Apr 30, 2025 •
edited by github-actions bot
Loading

Deprecate the silent layout switch, plan removal in 3.19 as per PEP 387.

Leave Windows alone; there's plenty of Windows-only ctypes code where this would just be noise.

📚 Documentation preview 📚: https://cpython-previews--133205.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request Apr 30, 2025
Open
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 2, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 85cee9f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133205%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 2, 2025
@encukou
Copy link
Member Author

encukou commented May 5, 2025

@ZeroIntensity, would you mind doing a quick review?

ZeroIntensity
ZeroIntensity approved these changes May 5, 2025
View reviewed changes
Doc/library/ctypes.rst Outdated Show resolved Hide resolved
Lib/test/test_ctypes/test_structunion.py
Comment on lines +343 to +344
if MS_WINDOWS:
warn_context = contextlib.nullcontext()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just skip the test on Windows?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to this to work everywhere (but warn only on non-Windows).

@encukou @ZeroIntensity
Update Doc/library/ctypes.rst
48261f6 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@encukou encukou merged commit 59f78d7 into python:main May 5, 2025
39 checks passed
@encukou encukou deleted the pack-warn branch May 5, 2025 13:32
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x (tier-3) has failed when building commit 59f78d7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1380/builds/3565) and take a look at the build logs.
  4. Check if the failure is related to this commit (59f78d7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1380/builds/3565

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 52, done.        
remote: Counting objects:   1% (1/52)        
remote: Counting objects:   3% (2/52)        
remote: Counting objects:   5% (3/52)        
remote: Counting objects:   7% (4/52)        
remote: Counting objects:   9% (5/52)        
remote: Counting objects:  11% (6/52)        
remote: Counting objects:  13% (7/52)        
remote: Counting objects:  15% (8/52)        
remote: Counting objects:  17% (9/52)        
remote: Counting objects:  19% (10/52)        
remote: Counting objects:  21% (11/52)        
remote: Counting objects:  23% (12/52)        
remote: Counting objects:  25% (13/52)        
remote: Counting objects:  26% (14/52)        
remote: Counting objects:  28% (15/52)        
remote: Counting objects:  30% (16/52)        
remote: Counting objects:  32% (17/52)        
remote: Counting objects:  34% (18/52)        
remote: Counting objects:  36% (19/52)        
remote: Counting objects:  38% (20/52)        
remote: Counting objects:  40% (21/52)        
remote: Counting objects:  42% (22/52)        
remote: Counting objects:  44% (23/52)        
remote: Counting objects:  46% (24/52)        
remote: Counting objects:  48% (25/52)        
remote: Counting objects:  50% (26/52)        
remote: Counting objects:  51% (27/52)        
remote: Counting objects:  53% (28/52)        
remote: Counting objects:  55% (29/52)        
remote: Counting objects:  57% (30/52)        
remote: Counting objects:  59% (31/52)        
remote: Counting objects:  61% (32/52)        
remote: Counting objects:  63% (33/52)        
remote: Counting objects:  65% (34/52)        
remote: Counting objects:  67% (35/52)        
remote: Counting objects:  69% (36/52)        
remote: Counting objects:  71% (37/52)        
remote: Counting objects:  73% (38/52)        
remote: Counting objects:  75% (39/52)        
remote: Counting objects:  76% (40/52)        
remote: Counting objects:  78% (41/52)        
remote: Counting objects:  80% (42/52)        
remote: Counting objects:  82% (43/52)        
remote: Counting objects:  84% (44/52)        
remote: Counting objects:  86% (45/52)        
remote: Counting objects:  88% (46/52)        
remote: Counting objects:  90% (47/52)        
remote: Counting objects:  92% (48/52)        
remote: Counting objects:  94% (49/52)        
remote: Counting objects:  96% (50/52)        
remote: Counting objects:  98% (51/52)        
remote: Counting objects: 100% (52/52)        
remote: Counting objects: 100% (52/52), done.        
remote: Compressing objects:   3% (1/26)        
remote: Compressing objects:   7% (2/26)        
remote: Compressing objects:  11% (3/26)        
remote: Compressing objects:  15% (4/26)        
remote: Compressing objects:  19% (5/26)        
remote: Compressing objects:  23% (6/26)        
remote: Compressing objects:  26% (7/26)        
remote: Compressing objects:  30% (8/26)        
remote: Compressing objects:  34% (9/26)        
remote: Compressing objects:  38% (10/26)        
remote: Compressing objects:  42% (11/26)        
remote: Compressing objects:  46% (12/26)        
remote: Compressing objects:  50% (13/26)        
remote: Compressing objects:  53% (14/26)        
remote: Compressing objects:  57% (15/26)        
remote: Compressing objects:  61% (16/26)        
remote: Compressing objects:  65% (17/26)        
remote: Compressing objects:  69% (18/26)        
remote: Compressing objects:  73% (19/26)        
remote: Compressing objects:  76% (20/26)        
remote: Compressing objects:  80% (21/26)        
remote: Compressing objects:  84% (22/26)        
remote: Compressing objects:  88% (23/26)        
remote: Compressing objects:  92% (24/26)        
remote: Compressing objects:  96% (25/26)        
remote: Compressing objects: 100% (26/26)        
remote: Compressing objects: 100% (26/26), done.        
remote: Total 28 (delta 24), reused 3 (delta 2), pack-reused 0 (from 0)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to '59f78d7b0609063d5eb7f2c2744540b47a8398fc'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 59f78d7b060 gh-131747: ctypes: Deprecate _pack_ implicitly setting _layout_ = 'ms' (GH-133205)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

make: *** [testios] Terminated: 15

@encukou
Copy link
Member Author

encukou commented May 5, 2025

That failure was a timeout; the next builds passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees
No one assigned
Labels
topic-ctypes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@encukou @bedevere-bot @ZeroIntensity
Morty Proxy This is a proxified and sanitized view of the page, visit original site.