Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-131798: JIT: Narrow the return type of isinstance for some known arguments #133172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 19, 2025
Merged

gh-131798: JIT: Narrow the return type of isinstance for some known arguments #133172

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
59b37f7
Optimize CALL_ISINSTANCE
tomasr8 Apr 26, 2025
a81c02e
Add news entry
tomasr8 Apr 26, 2025
b1eb6a0
Optimize for subclasses as well
tomasr8 Apr 29, 2025
c42172d
Merge branch 'main' into jit-isinstance
tomasr8 May 8, 2025
770f7ed
Regen cases
tomasr8 May 8, 2025
3e86810
Add a comment
tomasr8 May 8, 2025
0820a3c
Merge remote-tracking branch 'upstream/main' into jit-isinstance
tomasr8 May 8, 2025
60d21fa
Simplify
tomasr8 May 8, 2025
38370a3
Add a metaclass test
tomasr8 May 8, 2025
bb228eb
Improve test
tomasr8 May 8, 2025
0ede9f3
Update comment
tomasr8 May 9, 2025
3d0df4c
Mark some stackrefs as unused
tomasr8 May 9, 2025
ce0cd38
Simplify even more
tomasr8 May 9, 2025
20fd185
Simplify code
tomasr8 May 19, 2025
62854fe
Merge branch 'main' into jit-isinstance
brandtbucher May 19, 2025
f985963
make regen-cases
tomasr8 May 19, 2025
27b1b43
Merge branch 'main' into jit-isinstance
tomasr8 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a comment
  • Loading branch information
@tomasr8
tomasr8 committed May 8, 2025
commit 3e86810996d0ab276368916742a752ab0df16723
1 change: 1 addition & 0 deletions 1 Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,7 @@ dummy_func(void) {
// isinstance(obj, cls) where both obj and cls have known types
// We can deduce either True or False
PyTypeObject *inst_type = sym_get_type(inst_sym);
// The below check is equivalent to PyObject_TypeCheck(inst, cls)
if (sym_matches_type(inst_sym, cls) || PyType_IsSubtype(inst_type, cls)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simulates PyObject_TypeCheck

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment to that effect? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

res = sym_new_const(ctx, Py_True);
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.