-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF #132812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fba5efa
Add a test for union forward references
DavidCEllis d810953
Make stringifiers create unions if create_unions is True
DavidCEllis 1908a4a
modify broken test, move test to forwardref format group
DavidCEllis 97abdc7
Apparently trim trailing whitespace was turned off
DavidCEllis dd36a62
Alternative approach
JelleZijlstra 20f3dac
Merge remote-tracking branch 'upstream/main' into fix-union-forwardref
JelleZijlstra 8266a5e
fixes
JelleZijlstra 1c629dc
blurb
JelleZijlstra 3d7fec8
Handle displays
JelleZijlstra ec4dd0e
remove create_unions
JelleZijlstra 6e31c69
prefer empty dict
JelleZijlstra 525a4e4
Do not use special names in STRING format
JelleZijlstra 0a75e5f
Merge branch 'main' into extra-names
JelleZijlstra 7dec46b
Merge branch 'main' into extra-names
JelleZijlstra 22a9691
fix bad merge
JelleZijlstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make stringifiers create unions if create_unions is True
- Loading branch information
commit d8109538837278622b4f3809d5ae51af942ad9ac
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.