gh-127081: use getlogin_r if available
#132751
Conversation
The getlogin function is not thread-safe: replace with getlogin_r where available. Note that this function is untested (unit test is skipped with a note it caused CI failures as behaviour differs between NIX environments).
getlogin_r if available
…at order) if available, falling back to a hard-coded maximum login name length of 255 if neither is available.
The specific change or The existing (unconditionally skipped) test could be re-enabled, but it doesn't test very much at all, and presumably will still fail on some CI systems. Perhaps we could expand it to get the "correct" result to check against via a shell command? Then if/when it fails on specific platforms either skip or special-case the test for them? Testing the specific change: I can add a multi-threaded test, but it would ideally be conditional on having |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 675342c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132751%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
The getlogin function is not thread-safe: replace with getlogin_r where available.
Note that this function is untested (unit test is skipped with a note it caused CI failures as behaviour differs between NIX environments).