Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-132657: Add free-threading scaling benchmark for copy.copy and copy.deepcopy #132658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Apr 17, 2025

In this branch two benchmarks for the free-threading scaling are added. They are not completely microbenchmarks (they test multiple aspects of the free-threaded performance).

Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but in general my preference is to add these benchmarks when we fix the scaling issue. I think of these like regression tests, and having a mix of "passing" and "failing" cases makes it harder to notice regressions.

Tools/ftscalingbench/ftscalingbench.py Outdated Show resolved Hide resolved
Tools/ftscalingbench/ftscalingbench.py Outdated Show resolved Hide resolved
Co-authored-by: Sam Gross <colesbury@gmail.com>
@eendebakpt
Copy link
Contributor Author

Thanks for the feedback. I suspect we will only need one of the two benchmarks as a regression test (as the reason for not scaling seems to be the same). Once we have a better scaling, I will remove one of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.