Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

GH-132554: "Virtual" iterators #132555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: main
Choose a base branch
Loading
from
Open

GH-132554: "Virtual" iterators #132555

wants to merge 26 commits into from
+704 −581

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Apr 15, 2025 •
edited by bedevere-app bot
Loading

Just a draft PR until I have performance numbers.

@bedevere-app bedevere-app bot mentioned this pull request Apr 15, 2025
Open
@markshannon
Copy link
Member Author

Performance is good. Nothing amazing, but a small speedup.

Stats show no significant changes

@markshannon markshannon marked this pull request as ready for review April 30, 2025 11:38
iritkatriel
iritkatriel reviewed Apr 30, 2025
View reviewed changes
Include/internal/pycore_stackref.h Show resolved Hide resolved
Python/specialize.c Outdated Show resolved Hide resolved
Python/stackrefs.c Show resolved Hide resolved
Python/ceval.c Outdated Show resolved Hide resolved
Python/ceval.c Outdated Show resolved Hide resolved
Fidget-Spinner
Fidget-Spinner reviewed Apr 30, 2025
View reviewed changes
Python/ceval.c Outdated Show resolved Hide resolved
Fidget-Spinner
Fidget-Spinner reviewed May 1, 2025
View reviewed changes
Python/specialize.c Show resolved Hide resolved
Fidget-Spinner
Fidget-Spinner reviewed May 1, 2025
View reviewed changes
Python/ceval.c Outdated Show resolved Hide resolved
@markshannon markshannon mentioned this pull request May 8, 2025
Open
@ljfp ljfp mentioned this pull request May 8, 2025
Open
@Fidget-Spinner
Copy link
Member

@markshannon I don't think it matters here, but you didn't update in https://github.com/python/cpython/pull/132545/files Py_TAG_BITS to 3. It's still 1. I know it "technically" doesn't matter because we use a bitshift to zero it out, but we should still update it to be consistent.

@markshannon
Copy link
Member Author

@markshannon I don't think it matters here, but you didn't update in https://github.com/python/cpython/pull/132545/files Py_TAG_BITS to 3. It's still 1. I know it "technically" doesn't matter because we use a bitshift to zero it out, but we should still update it to be consistent.

Fixed in #134244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel left review comments

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markshannon @Fidget-Spinner @iritkatriel
Morty Proxy This is a proxified and sanitized view of the page, visit original site.