Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-132493: lazy evaluation of annotations in typing._proto_hook #132534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 16, 2025
Merged

gh-132493: lazy evaluation of annotations in typing._proto_hook #132534

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
34c6039
gh-132493: enable protocol isinstance checks against classes with def…
felixscherz Apr 14, 2025
8ad1181
fix: typo in test name
felixscherz Apr 15, 2025
079cf59
test: add case for class implementing protocol with deferred annotations
felixscherz Apr 15, 2025
998e83c
docs: add a news entry
felixscherz Apr 15, 2025
92e5ab9
docs: reference Protocol and isinstance correctly
felixscherz Apr 15, 2025
3413f78
feat: no longer check whether annotations is a mapping since it is gu…
felixscherz Apr 15, 2025
a82ac39
Merge branch 'main' into fix/protocol-isinstance-lazy-annotations
JelleZijlstra Apr 15, 2025
8c7a1e9
feat: check for Generic subclass and Protocol first to improve perfor…
felixscherz Apr 15, 2025
63e5a5b
test: add a test with a sub-protocol
felixscherz Apr 15, 2025
a820f7f
test: clarify override of method
felixscherz Apr 15, 2025
19d925a
test: fix test by removing non-member attribute
felixscherz Apr 15, 2025
316741e
feat: compute annotations only if necessary
felixscherz Apr 16, 2025
3d13c56
fix: replace assertTrue(...) with helper methods
felixscherz Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add case for class implementing protocol with deferred annotations
  • Loading branch information
@felixscherz
felixscherz committed Apr 15, 2025
commit 079cf59663d1fb5848e1f39b75e2b4b737d25e86
12 changes: 11 additions & 1 deletion 12 Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4557,14 +4557,24 @@ class Commentable(Protocol):
def test_isinstance_with_deferred_evaluation_of_annotations(self):
@runtime_checkable
class P(Protocol):
x: undefined
x: undefined | int
def meth(self):
...

class DeferredClass:
x: undefined

class DeferredClassImplementingP:
JelleZijlstra marked this conversation as resolved.
Show resolved Hide resolved
x: undefined | int

def __init__(self):
self.x = 0

def meth(self):
...

self.assertFalse(isinstance(DeferredClass(), P))
self.assertTrue(isinstance(DeferredClassImplementingP(), P))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a test with a class that does fulfill the protocol.

Also, please add a NEWS entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a class that satisfies the protocol and a NEWS entry:)


class GenericTests(BaseTestCase):
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.