Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-130167: Improve speed of _pydecimal._all_zeros and _pydecimal._exact_half by replacing re #132065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions 25 Lib/_pydecimal.py
Original file line number Diff line number Diff line change
Expand Up @@ -6076,8 +6076,29 @@ def _convert_for_comparison(self, other, equality_op=False):
\Z
""", re.VERBOSE | re.IGNORECASE).match

_all_zeros = re.compile('0*$').match
_exact_half = re.compile('50*$').match
# Checks for regex 0*$
def _all_zeros(d_int, prec=0):
i = prec
len_d = len(d_int)

while i < len_d:
if d_int[i] != '0':
return False
i += 1
return True

# Checks for regex 50*$
def _exact_half(d_int, prec=0):
len_d = len(d_int)
i = prec + 1

if len_d >= i and d_int[prec] == '5':
while i < len_d:
if d_int[i] != '0':
return False
i += 1
return True
return False

##### PEP3101 support functions ##############################################
# The functions in this section have little to do with the Decimal
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improved performance of :func:`_pydecimal._all_zeros` by an average of
~1.7x and :func:`_pydecimal._exact_half` by ~1.38x. Patch by Marius Juston
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.