Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-118761: Optimise import time for shlex #132036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2025
Merged

gh-118761: Optimise import time for shlex #132036

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1fd83f1
Optimise import time for ``shlex``
AA-Turner Apr 2, 2025
8811463
Revert deferral of sys and io
AA-Turner Apr 4, 2025
bd6916a
Switch to bytes.translate() based approach
AA-Turner Apr 6, 2025
192329e
Update Lib/shlex.py
AA-Turner Apr 18, 2025
cc130af
Merge branch 'main' into opt-shlex
AA-Turner Apr 18, 2025
4a640ce
Add test_lazy_imports
AA-Turner Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/shlex.py
  • Loading branch information
@AA-Turner
AA-Turner authored Apr 18, 2025
commit 192329ea333c1e19e5ef251161afe4f221217a78
3 changes: 2 additions & 1 deletion 3 Lib/shlex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,8 @@ def quote(s):
safe_chars = (b'%+,-./0123456789:=@'
b'ABCDEFGHIJKLMNOPQRSTUVWXYZ_'
b'abcdefghijklmnopqrstuvwxyz')
if not s.encode().translate(None, delete=safe_chars):
# No quoting is needed if `s` is an ASCII string consisting only of `safe_chars`
if s.isascii() and not s.encode().translate(None, delete=safe_chars):
return s

# use single quotes, and put single quotes into double quotes
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.