-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-130167: Add a What's New entry for changes to textwrap.{de,in}dent
#131924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1072,6 +1072,14 @@ io | |
:gh:`120754` and :gh:`90102`.) | ||
|
||
|
||
textwrap | ||
-------- | ||
|
||
* Optimise the :func:`~textwrap.dedent` function, improving performance by | ||
an average of 2.4x, with larger improvements for bigger inputs, | ||
and fix a bug with incomplete normalization of blank lines with whitespace | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe use two separate bullet points for that? so that the reader is able to distinguish between a performance improvement and a behavioral change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where should the second one go? Improved Modules is mainly for features, and a standalone bullet about the bugfix in Optimisations feels wrong. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, I think it's still an improvement in some sense (even if we didn't treat it as a regular bugfix that we backport). For me I think that the behavioral change is important to note, hence I suggested using two separate bullet points (but still under the same section) |
||
characters other than space and tab. | ||
|
||
Comment on lines
+1081
to
+1082
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add something like (to be able to see the issue) characters other than space and tab.
(Contributed by [...] in :gh:`...`.)
+ 2 blank lines to end the section. |
||
uuid | ||
---- | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is surprisingly a lot more common in the docs (41 compared to 0), also, you used it in the previous sentence.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on if Oxford spellings are acceptable! The verb was derived within English, but normal has a Latin root, not Greek, so perhaps we should normalise to normalise 1.
Footnotes
or normalize to normalize, of course! ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's at least have "normalizes" and "normalised" match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normaliz* is current the norm.
grep