Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-131831: Implement PEP 758 – Allow except and except* expressions without parentheses #131833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 1, 2025
Merged

gh-131831: Implement PEP 758 – Allow except and except* expressions without parentheses #131833

merged 10 commits into from
Apr 1, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 28, 2025 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 28, 2025
Closed
@pablogsal pablogsal requested a review from brettcannon March 28, 2025 12:16
pablogsal
pablogsal commented Mar 28, 2025
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
@pablogsal
Copy link
Member Author

I am missing a test for test_syntax that for some reason didn't committed. Will fix soon

brianschubert
brianschubert reviewed Mar 28, 2025
View reviewed changes
Doc/reference/compound_stmts.rst Outdated Show resolved Hide resolved
brianschubert
brianschubert reviewed Mar 28, 2025
View reviewed changes
Doc/reference/compound_stmts.rst Show resolved Hide resolved
brianschubert
brianschubert reviewed Mar 28, 2025
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
tomasr8
tomasr8 reviewed Mar 28, 2025
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
pablogsal
pablogsal commented Mar 28, 2025
View reviewed changes
Doc/reference/compound_stmts.rst Show resolved Hide resolved
@pablogsal
pythongh-131831: Implement PEP 758 – Allow except and except* express…
c03714f 
…ions without parentheses

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@AA-Turner @tomasr8
Typo (Cannin -> Cannon)
186035d 
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
AA-Turner
AA-Turner reviewed Mar 28, 2025
View reviewed changes
Lib/test/test_grammar.py Show resolved Hide resolved
pablogsal and others added 3 commits March 28, 2025 18:57
@pablogsal @brianschubert
Update Doc/whatsnew/3.14.rst
d04b864 
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@pablogsal @brianschubert
Update Doc/reference/compound_stmts.rst
72baf20 
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@pablogsal
Add news entry
c836244
brianschubert
brianschubert reviewed Mar 28, 2025
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
picnixz
picnixz reviewed Mar 28, 2025
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.14.rst Show resolved Hide resolved
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Wulian233
Wulian233 reviewed Mar 28, 2025
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
@pablogsal @picnixz @brianschubert
Apply suggestions from code review
0d09ad2 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
picnixz
picnixz reviewed Mar 29, 2025
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
vstinner
vstinner reviewed Mar 29, 2025
View reviewed changes
Doc/whatsnew/3.14.rst Show resolved Hide resolved
pablogsal
pablogsal commented Mar 31, 2025
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
pablogsal
pablogsal commented Mar 31, 2025
View reviewed changes
Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
brettcannon
brettcannon approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion about tweaking the exception message, otherwise LGTM!

Lib/test/test_syntax.py Outdated Show resolved Hide resolved
pablogsal and others added 2 commits March 31, 2025 20:14
@pablogsal @brettcannon
Update Lib/test/test_syntax.py
1a02bb7 
Co-authored-by: Brett Cannon <brett@python.org>
@pablogsal
update error message
955a433
@pablogsal pablogsal enabled auto-merge (squash) March 31, 2025 19:17
@pablogsal pablogsal merged commit c2ac662 into python:main Apr 1, 2025
42 checks passed
@pablogsal pablogsal deleted the notuples branch April 1, 2025 19:04
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@pablogsal @seehwan80
pythongh-131831: Implement PEP 758 – Allow except and except* express…
2ccdb98 
…ions without parentheses (python#131833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@tomasr8 tomasr8 tomasr8 left review comments

@AA-Turner AA-Turner AA-Turner left review comments

@picnixz picnixz picnixz left review comments

@brianschubert brianschubert brianschubert left review comments

@Wulian233 Wulian233 Wulian233 left review comments

@brettcannon brettcannon brettcannon approved these changes

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PEP 758 – Allow except and except* expressions without parentheses
8 participants
@pablogsal @brettcannon @vstinner @tomasr8 @AA-Turner @picnixz @brianschubert @Wulian233
Morty Proxy This is a proxified and sanitized view of the page, visit original site.