Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-128813: hide mixed-mode functions for complex arithmetic from C-API#131703

Merged
vstinner merged 2 commits intopython:mainpython/cpython:mainfrom
skirpichev:remove-mixed-api/128813skirpichev/cpython:remove-mixed-api/128813Copy head branch name to clipboard
Apr 22, 2025
Merged

gh-128813: hide mixed-mode functions for complex arithmetic from C-API#131703
vstinner merged 2 commits intopython:mainpython/cpython:mainfrom
skirpichev:remove-mixed-api/128813skirpichev/cpython:remove-mixed-api/128813Copy head branch name to clipboard

Conversation

@skirpichev
Copy link
Member

@skirpichev skirpichev commented Mar 25, 2025

@skirpichev
Copy link
Member Author

CC @vstinner

Modules/_testcapi/complex.c Outdated Show resolved Hide resolved
@skirpichev skirpichev requested review from a team and erlend-aasland as code owners March 25, 2025 08:40
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev
Copy link
Member Author

skirpichev commented Apr 15, 2025

CC @serhiy-storchaka

I doubt C-API WG issue will be solved til 3.14 beta1. So, lets remove added functions from the public API.

@skirpichev
Copy link
Member Author

CC @erlend-aasland

@vstinner
Copy link
Member

Related discussion: capi-workgroup/decisions#56

@skirpichev
Copy link
Member Author

I just worry, that it will be not finished til 3.14 beta. Or it's ok to revert this stuff after that?

@vstinner vstinner merged commit 79f7c67 into python:main Apr 22, 2025
48 checks passed
@vstinner
Copy link
Member

Ok, let's remove them for now. We can revisit this API later if we decide to expose it.

@skirpichev skirpichev deleted the remove-mixed-api/128813 branch April 22, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.