Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

GH-130614: pathlib ABCs: retain original separator in with_name() #130990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Mar 8, 2025

In pathlib.types._JoinablePath.with_name(), retain any alternative path separator preceding the old name, rather stripping and replacing it with a primary separator. As a result, this method changes only the name.

Testing will be covered by #130988.

…e()`

In `pathlib.types._JoinablePath.with_name()`, retain any alternative path
separator preceding the old name, rather stripping and replacing it with a
primary separator. As a result, this method changes _only_ the name.
@barneygale barneygale merged commit ba64cc5 into python:main Mar 9, 2025
44 checks passed
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
…e()` (python#130990)

In `pathlib.types._JoinablePath.with_name()`, retain any alternative path
separator preceding the old name, rather stripping and replacing it with a
primary separator. As a result, this method changes _only_ the name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.