Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-118518: Minor improvements to perf docs #130866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

gh-118518: Minor improvements to perf docs #130866

merged 1 commit into from
Mar 10, 2025

Conversation

stratakis
Copy link
Contributor

@stratakis stratakis commented Mar 5, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 5, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Mar 5, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 5, 2025
Closed
@stratakis
Copy link
Contributor Author

cc @pablogsal

jstasiak
jstasiak reviewed Mar 8, 2025
View reviewed changes
Copy link
Contributor

@jstasiak jstasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes actually related to the linked ticket?

FWIW I'd probably not attach this PR to a ticket that's been closed for that long.

@stratakis
Copy link
Contributor Author

The -k flag for perf is required for jited code so it's related to the linked ticket where the support was initially implemented. The rename of the script harmonizes the commands with the rest of the examples there.

pablogsal
pablogsal approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR @stratakis

@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Mar 10, 2025
@pablogsal pablogsal enabled auto-merge (squash) March 10, 2025 21:51
@pablogsal pablogsal merged commit ecdf6b1 into python:main Mar 10, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Mar 10, 2025
@miss-islington-app
Copy link

Thanks @stratakis for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2025
@stratakis @miss-islington
pythongh-118518: Minor improvements to perf docs (pythonGH-130866)
c7a085c 
Minor improvements to perf docs
(cherry picked from commit ecdf6b1)

Co-authored-by: stratakis <cstratak@redhat.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 10, 2025

GH-131059 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 10, 2025
pablogsal pushed a commit that referenced this pull request Mar 28, 2025
@miss-islington @stratakis
[3.13] gh-118518: Minor improvements to perf docs (GH-130866) (#131059)
7f7fc54 
gh-118518: Minor improvements to perf docs (GH-130866)

Minor improvements to perf docs
(cherry picked from commit ecdf6b1)

Co-authored-by: stratakis <cstratak@redhat.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@stratakis @seehwan80
pythongh-118518: Minor improvements to perf docs (python#130866)
5238d76 
Minor improvements to perf docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstasiak jstasiak jstasiak left review comments

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stratakis @jstasiak @pablogsal
Morty Proxy This is a proxified and sanitized view of the page, visit original site.