Docs: improve covariance generic typing examples #130302
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
skip issue |
|
The original documentation did not include a declaration for |
|
I don't think we need this many additional examples. Let's try to keep the examples short and focused. It may be enough to just add a |
Let me argue, then this section does not give the reader information about how typing with inheritance will work in this case. If it’s ok, then fine, I’ll remove the unnecessary stuff. |
| @@ -421,8 +423,9 @@ Note that ``type[C]`` is covariant:: | ||
| return user_class() | ||
|
|
||
| make_new_user(User) # OK | ||
| make_new_user(ProUser) # Also OK: ``type[ProUser]`` is a subtype of ``type[User]`` | ||
| make_new_user(TeamUser) # Still fine | ||
| make_new_user(BasicUser) # Also OK: ``type[BasicUser]`` is a subtype of ``type[User]`` |
There was a problem hiding this comment.
This now demonstrates the exact same thing three times. I think we only need one. We can keep one of the three subclasses in this test, and move the remaining two class definitions to the next test.
📚 Documentation preview 📚: https://cpython-previews--130302.org.readthedocs.build/