Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-129805: Fix bytes annotation in Tools/jit #129806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

gh-129805: Fix bytes annotation in Tools/jit #129806

merged 1 commit into from
Feb 17, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 7, 2025 •
edited by bedevere-app bot
Loading

I can confirm that this now passes --strict-bytes check from mypy:

(.venv) ~/Desktop/cpython2  issue-129805 ✔                                                
» mypy --version
mypy 1.15.0 (compiled: yes)
                                                                                           
(.venv) ~/Desktop/cpython2  issue-129805 ✔                                                
» mypy --config-file=Tools/jit/mypy.ini --strict-bytes            
Success: no issues found in 6 source files

We can yet use mypy@1.15 in CPython to verify it, because there are known regressions :(

@bedevere-app bedevere-app bot mentioned this pull request Feb 7, 2025
Closed
@sobolevn sobolevn requested a review from AlexWaygood February 16, 2025 19:42
@sobolevn sobolevn merged commit 422f8e9 into python:main Feb 17, 2025
70 checks passed
@sobolevn sobolevn added the needs backport to 3.13 bugs and security fixes label Feb 17, 2025
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 422f8e9e02e68d45aee3846751a003a70fca13b6 3.13

sobolevn added a commit to sobolevn/cpython that referenced this pull request Feb 17, 2025
@sobolevn
[3.13] pythongh-129805: Fix bytes annotation in Tools/jit (python…
ba30d8b 
…GH-129806)

(cherry picked from commit 422f8e9)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Feb 17, 2025

GH-130216 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 17, 2025
sobolevn added a commit that referenced this pull request Feb 17, 2025
@sobolevn
[3.13] gh-129805: Fix bytes annotation in Tools/jit (GH-129806) (#…
4d941d3 
…130216)

(cherry picked from commit 422f8e9)
brandtbucher added a commit to brandtbucher/cpython that referenced this pull request May 6, 2025
@brandtbucher
Clean up some changes from pythonGH-129806
075acec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Assignees

@sobolevn sobolevn

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @AlexWaygood
Morty Proxy This is a proxified and sanitized view of the page, visit original site.