Added filtering logic based on the included/excluded items in ns #129571
Conversation
Added filtering logic based on the included/excluded items in ns
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
This needs an issue, a news entry and an explanation of why this is needed. cc @zooba as the PC expert |
There was a problem hiding this comment.
This is not at all the filtering that was intended by the comment.
In PROPS_TEMPLATE you'll see XML elements for _PythonRuntimeExe and _PythonRuntimeDlls, some of which don't need to be included at all if the package doesn't include those files. Though the only really relevant ones are python*.exe and python*.dll for the cases where someone chooses to build a package that doesn't include Python itself (which would be weird).
So this is unnecessary, and probably marking the comment "TODO" is too attractive for contributions when really it should just say "We don't filter based on contents, so if you expected it, that's why" to help out anyone who comes looking at the code to figure out why their weird incantation isn't working.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
Added filtering logic based on the included/excluded items in ns