Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[3.13] gh-128679: Fix tracemalloc.stop() race conditions #128897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 18, 2025
Merged

[3.13] gh-128679: Fix tracemalloc.stop() race conditions #128897

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
545053f
gh-128679: Fix tracemalloc.stop() race conditions
vstinner Jan 15, 2025
be6f0e2
Fix the race condition in more functions
vstinner Jan 16, 2025
ef1718b
Lock also in _PyTraceMalloc_IsTracing()
vstinner Jan 16, 2025
99d27fe
_PyTraceMalloc_Start(): lock before reading tracing
vstinner Jan 16, 2025
54c8f9e
Call _PyTraceMalloc_Init() at Python startup
vstinner Jan 16, 2025
aa85a70
gh-128679: Skip test_tracemalloc_track_race() on debug build (#128988)
vstinner Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lock also in _PyTraceMalloc_IsTracing()
  • Loading branch information
@vstinner
vstinner committed Jan 16, 2025
commit ef1718b0ed70089e3933be586bcfbf549649e19f
5 changes: 4 additions & 1 deletion 5 Python/tracemalloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,7 +1445,10 @@ _PyTraceMalloc_GetTraceback(unsigned int domain, uintptr_t ptr)
int
_PyTraceMalloc_IsTracing(void)
{
return tracemalloc_config.tracing;
TABLES_LOCK();
int tracing = tracemalloc_config.tracing;
TABLES_UNLOCK();
return tracing;
}

void
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.