Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[3.12] gh-128588: gh-128550: gh-128552: fix refcycles in eager task creation (#128553) and remove eager tasks optimization that missed and introduced incorrect cancellations (python#129063) #128586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 21, 2025
Merged

[3.12] gh-128588: gh-128550: gh-128552: fix refcycles in eager task creation (#128553) and remove eager tasks optimization that missed and introduced incorrect cancellations (python#129063) #128586

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f624a0
gh-128552: fix refcycles in eager task creation (#128553)
graingert Jan 7, 2025
9df724e
Update Lib/test/test_asyncio/test_taskgroups.py
graingert Jan 7, 2025
e92aed1
remove tests only valid in 3.13
graingert Jan 7, 2025
2246cfa
Merge branch '3.12' into backport-61b9811-3.12
graingert Jan 20, 2025
958bb1c
Merge branch '3.12' into backport-61b9811-3.12
graingert Jan 20, 2025
59aff22
gh-128588: gh-128550: remove eager tasks optimization that missed and…
graingert Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/test/test_asyncio/test_taskgroups.py
  • Loading branch information
@graingert
graingert authored Jan 7, 2025
commit 9df724eea736d2117961444573a2c10912eb1073
2 changes: 2 additions & 0 deletions 2 Lib/test/test_asyncio/test_taskgroups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,8 @@ async def test_taskgroup_without_parent_task(self):
coro = asyncio.sleep(0)
with self.assertRaisesRegex(RuntimeError, "has not been entered"):
tg.create_task(coro)
# We still have to await coro to avoid a warning
await coro

graingert marked this conversation as resolved.
Show resolved Hide resolved
async def test_coro_closed_when_tg_closed(self):
async def run_coro_after_tg_closes():
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.