-
-
Notifications
You must be signed in to change notification settings - Fork 32k
GH-127429: fix sysconfig data generation on cross-builds #127430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Filipe Laíns <lains@riseup.net>
@nascheme, this should fix the JIT tests. |
Signed-off-by: Filipe Laíns <lains@riseup.net>
…ts :) Signed-off-by: Filipe Laíns <lains@riseup.net>
…piling Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Alright, the tests seem to be passing 😄 |
Okay, there seems to be an issue still:
|
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
It seems like |
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Oh, yay, all tests pass, that wasn't much fun to debug 😅 |
Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, @FFY00, I could not cleanly backport this to
|
Sorry, @FFY00, I could not cleanly backport this to
|
@FFY00 Triage: please could you make the backports if they're still needed? Otherwise let's remove the labels. |
…pythonGH-127430) (cherry picked from commit 2950bc5) Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
@@ -161,7 +162,7 @@ def _print_config_dict(d, stream): | ||
|
||
def _get_pybuilddir(): | ||
pybuilddir = f'build/lib.{get_platform()}-{get_python_version()}' | ||
if hasattr(sys, "gettotalrefcount"): | ||
if get_config_var('Py_DEBUG') == '1': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_config_var('Py_DEBUG')
is an int
rather than str
.
Uh oh!
There was an error while loading. Please reload this page.