-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-108951: add TaskGroup.cancel() #127214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
belm0
wants to merge
10
commits into
python:main
Choose a base branch
from
belm0:task_group_stop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8ec2f60
add TaskGroup.stop()
belm0 907f1d0
馃摐馃 Added by blurb_it.
blurb-it[bot] 2cfa1e6
minor doc fixes
belm0 bce1fb1
make tests more explicit
belm0 7754aad
use versionadded:: next
belm0 452042d
stop() -> cancel()
belm0 f077241
document some ways to use cancel()
belm0 8345647
fix cases of exception in task group body before/after cancel()
belm0 7235c20
add test for create_task() following cancel()
belm0 243db79
Merge branch 'main' into task_group_stop
asvetlov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add test for create_task() following cancel()
- Loading branch information
commit 7235c20989391bb99e37863fd7bcebdce7156e0a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copying comment from @graingert
(please make all comments on the code so that there can be a thread and Resolve button)