gh-115999: Don't take a reason in unspecialize#127030
Merged
mpage merged 2 commits intopython:mainpython/cpython:mainfrom Nov 20, 2024
mpage:gh-115999-dont-pass-reason-to-unspecializempage/cpython:gh-115999-dont-pass-reason-to-unspecializeCopy head branch name to clipboard
Merged
gh-115999: Don't take a reason in unspecialize#127030mpage merged 2 commits intopython:mainpython/cpython:mainfrom mpage:gh-115999-dont-pass-reason-to-unspecializempage/cpython:gh-115999-dont-pass-reason-to-unspecializeCopy head branch name to clipboard
mpage merged 2 commits intopython:mainpython/cpython:mainfrom
mpage:gh-115999-dont-pass-reason-to-unspecializempage/cpython:gh-115999-dont-pass-reason-to-unspecializeCopy head branch name to clipboard
Conversation
We only want to compute the reason if stats are enabled. Optimizing compilers should optimize this away for us (gcc and clang do), but it's better to be safe than sorry.
corona10
approved these changes
Nov 20, 2024
Member
corona10
left a comment
There was a problem hiding this comment.
lgtm, because it just move back to previous version.
Sharing my one of idea is (I didn't take a look deeply if it is possible or not):
- providing two version of xxxx_op_fail_kind function based
Py_STATSand ifPy_STATSis disabled, just return dummy value like -1, - Inside
unspecialize(_Py_CODEUNIT *instr, int reason), if the reason is just dummy value than calculate nothing.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Don't take a reason in unspecialize We only want to compute the reason if stats are enabled. Optimizing compilers should optimize this away for us (gcc and clang do), but it's better to be safe than sorry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only want to compute the reason if stats are enabled. Optimizing compilers should optimize this away for us (gcc and clang do), but it's better to be safe than sorry.
--disable-gilbuilds #115999