gh-115999: Add free-threaded specialization for COMPARE_OP#126410
gh-115999: Add free-threaded specialization for COMPARE_OP#126410Yhg1s merged 5 commits intopython:mainpython/cpython:mainfrom
Conversation
mpage
left a comment
There was a problem hiding this comment.
LGTM! Please add a short explanation of why the specialized instructions are thread-safe to either the pull request or the commit (when it's merged).
markshannon
left a comment
There was a problem hiding this comment.
The approach looks sound, but the test will need moving and should not rely on specific sequences of instructions.
|
When you're done making the requested changes, leave the comment: |
…E_OP specialization in general.
Sorry, that's Google for: I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @markshannon, @mpage: please review the changes made to this pull request. |
mpage
left a comment
There was a problem hiding this comment.
LGTM. I queued benchmark runs for both the free-threaded and default builds for this PR. Let's wait until we have the results before merging this.
|
Performance doesn't look like a blocker:
|
|
@markshannon All your concerns should have been addressed, do you want to take another look? |
…hon#126410) Add free-threaded specialization for COMPARE_OP, and tests for COMPARE_OP specialization in general. Co-authored-by: Donghee Na <donghee.na92@gmail.com>
Add free-threaded specialization for COMPARE_OP, and tests for COMPARE_OP specialization in general. This relies on thread-local bytecode and atomic operations to update the counters and bytecode, which are single operations.
--disable-gilbuilds #115999