gh-126366: Make native generators thread safe#126371
Draft
ZeroIntensity wants to merge 44 commits intopython:mainpython/cpython:mainfrom
ZeroIntensity:list-init-thread-safetyZeroIntensity/cpython:list-init-thread-safetyCopy head branch name to clipboard
Draft
gh-126366: Make native generators thread safe#126371ZeroIntensity wants to merge 44 commits intopython:mainpython/cpython:mainfrom ZeroIntensity:list-init-thread-safetyZeroIntensity/cpython:list-init-thread-safetyCopy head branch name to clipboard
ZeroIntensity wants to merge 44 commits intopython:mainpython/cpython:mainfrom
ZeroIntensity:list-init-thread-safetyZeroIntensity/cpython:list-init-thread-safetyCopy head branch name to clipboard
Conversation
Member
|
cc @colesbury |
Member
|
I will try to take a look at today :) |
colesbury
reviewed
Nov 4, 2024
list.__init__
Member
Author
|
Closing in favor of #120327 |
Member
|
Wait I closed my PR in favour of yours... 😆 @ZeroIntensity |
Member
Author
|
Ah! I'll reopen this and list you as a co-author if yours has merge conflicts. |
vstinner
reviewed
Dec 25, 2024
Member
vstinner
left a comment
There was a problem hiding this comment.
There is a warning:
Check warning on line 129 in Python/ceval_macros.h
‘gen_frame’ may be used uninitialized in this function [-Wmaybe-uninitialized]
vstinner
reviewed
Dec 25, 2024
Member
vstinner
left a comment
There was a problem hiding this comment.
The overall approach LGTM. I'm feeling more confortable with more critical sections :-)
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ken Jin kenjin@python.org
ChainMapof aCounterin threads #126366