-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-61011: Fix inheritance of nested mutually exclusive groups in argparse #125210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
serhiy-storchaka
merged 1 commit into
python:main
from
serhiy-storchaka:argparse-mutex-parent3
Oct 11, 2024
Merged
gh-61011: Fix inheritance of nested mutually exclusive groups in argparse #125210
serhiy-storchaka
merged 1 commit into
python:main
from
serhiy-storchaka:argparse-mutex-parent3
Oct 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n argparse Previously, all nested mutually exclusive groups lost their connection to the group containing them and were displayed as belonging directly to the parser. Co-authored-by: Danica J. Sutherland <djsutherland@users.noreply.github.com>
a5ffa74
to
30e211c
Compare
savannahostrowski
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled this down and tested it out. This LGTM.
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 11, 2024
…n argparse (pythonGH-125210) Previously, all nested mutually exclusive groups lost their connection to the group containing them and were displayed as belonging directly to the parser. (cherry picked from commit 18c7449) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Danica J. Sutherland <djsutherland@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 11, 2024
…n argparse (pythonGH-125210) Previously, all nested mutually exclusive groups lost their connection to the group containing them and were displayed as belonging directly to the parser. (cherry picked from commit 18c7449) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Danica J. Sutherland <djsutherland@users.noreply.github.com>
GH-125308 is a backport of this pull request to the 3.13 branch. |
GH-125309 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 11, 2024
…in argparse (GH-125210) (GH-125309) Previously, all nested mutually exclusive groups lost their connection to the group containing them and were displayed as belonging directly to the parser. (cherry picked from commit 18c7449) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Danica J. Sutherland <djsutherland@users.noreply.github.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 11, 2024
…in argparse (GH-125210) (GH-125308) Previously, all nested mutually exclusive groups lost their connection to the group containing them and were displayed as belonging directly to the parser. (cherry picked from commit 18c7449) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Danica J. Sutherland <djsutherland@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all nested mutually exclusive groups lost their connection to the group containing them and were displayed as belonging directly to the parser.