Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

GH-115506: Improve handling of constants in tier two #124809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

GH-115506: Improve handling of constants in tier two #124809

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
279e61d
Promote immortal locals to constants
brandtbucher Aug 7, 2024
89d6d45
Promote constant math and locals to constant loads
brandtbucher Aug 7, 2024
8977c39
Promote constant copies to constant loads
brandtbucher Aug 7, 2024
60e1e10
Deduplicate constants, and make some attribute loads constant
brandtbucher Aug 7, 2024
0dfd1fe
Constant merging isn't needed for anything already created
brandtbucher Aug 7, 2024
0d2e040
Improve handling of _POP_TOP_LOAD_CONST_INLINE_BORROW and _REPLACE_WI…
brandtbucher Aug 7, 2024
8e6e406
Remove original or unused constants
brandtbucher Aug 22, 2024
cc185ce
fixup
brandtbucher Aug 28, 2024
adfacc1
Don't resurrect dead caches
brandtbucher Aug 28, 2024
d93c5a3
Don't bother deduplicating (and factor out some repeated code)
brandtbucher Aug 28, 2024
cc0d30f
blurb add
brandtbucher Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't resurrect dead caches
  • Loading branch information
@brandtbucher
brandtbucher committed Sep 30, 2024
commit adfacc1cb380cb722a0e50cd447d2d3ba651da30
8 changes: 4 additions & 4 deletions 8 Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,27 +611,27 @@ dummy_func(void) {
}

op(_LOAD_ATTR_CLASS, (descr/4, owner -- attr, null if (oparg & 1))) {
attr = sym_new_const(ctx, descr);
attr = sym_new_not_null(ctx);
null = sym_new_null(ctx);
(void)descr;
(void)owner;
}

op(_LOAD_ATTR_METHOD_WITH_VALUES, (descr/4, owner -- attr, self if (1))) {
(void)descr;
attr = sym_new_const(ctx, descr);
attr = sym_new_not_null(ctx);
self = owner;
}

op(_LOAD_ATTR_METHOD_NO_DICT, (descr/4, owner -- attr, self if (1))) {
(void)descr;
attr = sym_new_const(ctx, descr);
attr = sym_new_not_null(ctx);
self = owner;
}

op(_LOAD_ATTR_METHOD_LAZY_DICT, (descr/4, owner -- attr, self if (1))) {
(void)descr;
attr = sym_new_const(ctx, descr);
attr = sym_new_not_null(ctx);
self = owner;
}

Expand Down
8 changes: 4 additions & 4 deletions 8 Python/optimizer_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Morty Proxy This is a proxified and sanitized view of the page, visit original site.